Add player attributes from Hexxy Attributes #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attributes for being allowed to staffcast, media consumption, player ambit radius, and sentinel ambit radius code largely based on justs_js' Hexxy Attributes addon, PR made with his permission
|
Can I get a second pair of eyes on this? @object-Object @SamsTheNerd ? |
SamsTheNerd
approved these changes
Jan 14, 2025
| @@ -25,6 +26,9 @@ public ItemStaff(Properties pProperties) { | |||
|
|
|||
| @Override | |||
| public InteractionResultHolder<ItemStack> use(Level world, Player player, InteractionHand hand) { | |||
| if (player.getAttributeValue(HexAttributes.FEEBLE_MIND) > 0){ | |||
There was a problem hiding this comment.
Nvm, I think it should be fine since they're marked syncable?
| out.add(HexAttributes.FEEBLE_MIND); | ||
| out.add(HexAttributes.MEDIA_CONSUMPTION_MODIFIER); | ||
| out.add(HexAttributes.AMBIT_RADIUS); | ||
| out.add(HexAttributes.SENTINEL_RADIUS); |
There was a problem hiding this comment.
Should these be like,, auto grabbed out of the HexAttributes instead of manually listed in 3 separate places?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is largely based on that of Hexxy Attributes by justs_js, PR'd with his permission.
https://discord.com/channels/936370934292549712/1011455473528098857/1327275691343085578