Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout because of large result set #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoernHe
Copy link

@JoernHe JoernHe commented Jan 29, 2024

I encountered timeout errors several times in a really large environment when cn=aa* was not enough. Hence the pull request, which always checks for each cn whether the threshold size has been exceeded. If so, a char is appended to the request.
So the program dynamically goes deeper if the result set is too large. (=> cn=aaa*, cn=aaaa* ...)

@0xFF-NK
Copy link
Collaborator

0xFF-NK commented Jan 30, 2024

Thanks for the PR, the recursive split is a great idea. However, you might end-up missing objects containing non alphanumerical characters. For example, let's say you have "adcs", "adfs" and "ad-connect" and you hit the threshold on "ad". When you recurse to the 3rd depth level, you will miss the "ad-connect" object. A workaround could be to add special characters in the alphabet of your recursive queries, but this needs more testing. We will merge the PR once we have properly evaluated this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants