Merge pull request #101 from FakeDevelopers/feature/BDBD-531

FEAT : BaseFragment에 initListener, initCollector 추가
FakeDevelopers · Feb 16, 2023 · f0ab3c2 · f0ab3c2
2 parents de0796f + 8b0280d
commit f0ab3c2
Show file tree

Hide file tree

Showing 16 changed files with 209 additions and 406 deletions.
diff --git a/presentation/src/main/java/com/fakedevelopers/presentation/ui/base/BaseFragment.kt b/presentation/src/main/java/com/fakedevelopers/presentation/ui/base/BaseFragment.kt
@@ -31,7 +31,21 @@ abstract class BaseFragment<VB : ViewDataBinding>(
         }
     }
 
-    fun sendSnackBar(
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        initListener()
+        initCollector()
+    }
+
+    protected open fun initListener() {
+        // 호출을 BaseFragment로 위임하기 위한 빈 메소드 입니다.
+    }
+
+    protected open fun initCollector() {
+        // 호출을 BaseFragment로 위임하기 위한 빈 메소드 입니다.
+    }
+
+    protected fun sendSnackBar(
         message: String,
         @IntRange(from = -2) length: Int = Snackbar.LENGTH_SHORT,
         anchorView: View? = null
@@ -47,7 +61,7 @@ abstract class BaseFragment<VB : ViewDataBinding>(
         }.show()
     }
 
-    fun navigateActivity(activity: Class<*>) {
+    protected fun navigateActivity(activity: Class<*>) {
         startActivity(Intent(requireContext(), activity))
         requireActivity().finish()
     }

diff --git a/...tion/src/main/java/com/fakedevelopers/presentation/ui/chat/channel/ChannelListFragment.kt b/...tion/src/main/java/com/fakedevelopers/presentation/ui/chat/channel/ChannelListFragment.kt
@@ -38,8 +38,6 @@ class ChannelListFragment : BaseFragment<FragmentChannelListBinding>(
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         binding.vm = viewModel
-        initCollector()
-        initListener()
     }
 
     override fun onStart() {
@@ -49,7 +47,7 @@ class ChannelListFragment : BaseFragment<FragmentChannelListBinding>(
         }
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         lifecycleScope.launch {
             viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) {
                 viewModel.streamUserTokenEvent.collectLatest { result ->
@@ -65,7 +63,7 @@ class ChannelListFragment : BaseFragment<FragmentChannelListBinding>(
         }
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.channelListChat.setChannelItemClickListener { channel ->
             findNavController().navigate(
                 ChannelListFragmentDirections.actionChannelListFragmentToChattingFragment(channel.cid)

diff --git a/presentation/src/main/java/com/fakedevelopers/presentation/ui/login/LoginFragment.kt b/presentation/src/main/java/com/fakedevelopers/presentation/ui/login/LoginFragment.kt
@@ -24,17 +24,15 @@ class LoginFragment : BaseFragment<FragmentLoginBinding>(
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         binding.vm = viewModel
-        initListener()
-        initCollector()
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.textviewLoginRegistration.setOnClickListener {
             findNavController().navigate(R.id.action_loginFragment_to_userRegistrationFragment)
         }
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.loginEvent.collectLatest { result ->
                 if (result.isSuccess && result.getOrThrow() == LOGIN_SUCCESS) {

diff --git a/presentation/src/main/java/com/fakedevelopers/presentation/ui/loginType/LoginTypeFragment.kt b/presentation/src/main/java/com/fakedevelopers/presentation/ui/loginType/LoginTypeFragment.kt
@@ -61,11 +61,9 @@ class LoginTypeFragment : BaseFragment<FragmentLoginTypeBinding>(
                     Spannable.SPAN_EXCLUSIVE_EXCLUSIVE
                 )
             }
-        initListener()
-        initCollector()
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.buttonLogintypeGoogle.setOnClickListener {
             googleLogin()
         }
@@ -77,7 +75,7 @@ class LoginTypeFragment : BaseFragment<FragmentLoginTypeBinding>(
         }
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.loginWithGoogleEvent.collect { result ->
                 if (result.isSuccess) {

diff --git a/...n/src/main/java/com/fakedevelopers/presentation/ui/productDetail/ProductDetailFragment.kt b/...n/src/main/java/com/fakedevelopers/presentation/ui/productDetail/ProductDetailFragment.kt
@@ -55,19 +55,17 @@ class ProductDetailFragment : BaseFragment<FragmentProductDetailBinding>(
             adapter = productDetailAdapter
             registerOnPageChangeCallback(onPageChanged)
         }
-        initCollector()
-        initListener()
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.eventFlow.collect { event ->
                 handleEvent(event)
             }
         }
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.toolbarProductDetail.buttonToolbarBack.setOnClickListener {
             findNavController().popBackStack()
         }

diff --git a/...n/src/main/java/com/fakedevelopers/presentation/ui/productEditor/ProductEditorFragment.kt b/...n/src/main/java/com/fakedevelopers/presentation/ui/productEditor/ProductEditorFragment.kt
@@ -13,6 +13,7 @@ import android.widget.ArrayAdapter
 import android.widget.EditText
 import androidx.activity.result.ActivityResultLauncher
 import androidx.activity.result.contract.ActivityResultContracts
+import androidx.annotation.CallSuper
 import androidx.annotation.StringRes
 import androidx.core.content.PermissionChecker
 import androidx.core.content.PermissionChecker.checkCallingOrSelfPermission
@@ -79,8 +80,6 @@ abstract class ProductEditorFragment(
         if (viewModel.category.isNotEmpty()) {
             setCategory(viewModel.category)
         }
-        initListener()
-        initCollector()
     }
 
     override fun onStart() {
@@ -111,7 +110,8 @@ abstract class ProductEditorFragment(
 
     protected abstract fun initSelectedImages()
 
-    protected open fun initListener() {
+    @CallSuper
+    override fun initListener() {
         // 가격 필터 등록
         binding.edittextProductEditorHopePrice.setPriceFilter(MAX_PRICE_LENGTH)
         binding.edittextProductEditorOpeningBid.setPriceFilter(MAX_PRICE_LENGTH)
@@ -170,7 +170,8 @@ abstract class ProductEditorFragment(
         }
     }
 
-    protected open fun initCollector() {
+    @CallSuper
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.productEditorResponse.collectLatest {
                 if (it.isSuccess) {

diff --git a/...main/java/com/fakedevelopers/presentation/ui/productEditor/albumList/AlbumListFragment.kt b/...main/java/com/fakedevelopers/presentation/ui/productEditor/albumList/AlbumListFragment.kt
@@ -58,8 +58,6 @@ class AlbumListFragment : BaseFragment<FragmentAlbumListBinding>(
             setCompleteTextVisibility(args.selectedImageInfo.uris.size)
         }
         binding.recyclerAlbumList.itemAnimator = null
-        initListener()
-        initCollector()
     }
 
     override fun onStart() {
@@ -88,7 +86,7 @@ class AlbumListFragment : BaseFragment<FragmentAlbumListBinding>(
         }
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.toolbarAlbumList.run {
             textviewAlbumComplete.setOnClickListener {
                 toProductEditor(args.selectedImageInfo)
@@ -112,7 +110,7 @@ class AlbumListFragment : BaseFragment<FragmentAlbumListBinding>(
             .attachToRecyclerView(binding.recyclerSelectedPicture)
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.event.collect { event ->
                 handleEvent(event)

diff --git a/.../java/com/fakedevelopers/presentation/ui/productEditor/albumSelect/AlbumSelectFragment.kt b/.../java/com/fakedevelopers/presentation/ui/productEditor/albumSelect/AlbumSelectFragment.kt
@@ -39,6 +39,16 @@ class AlbumSelectFragment : BaseFragment<FragmentAlbumSelectBinding>(
         super.onViewCreated(view, savedInstanceState)
         viewModel.initAlbumInfo(getString(R.string.album_select_recent_images))
         binding.recyclerAlbumSelect.adapter = adapter
+        if (args.selectedImageInfo.uris.isNotEmpty()) {
+            binding.toolbarAlbumSelect.run {
+                textviewAlbumComplete.isEnabled = true
+                textviewAlbumComplete.setTextColor(ContextCompat.getColor(requireContext(), R.color.black))
+                textviewAlbumCount.text = args.selectedImageInfo.uris.size.toString()
+            }
+        }
+    }
+
+    override fun initListener() {
         val toolbarTitle = getString(R.string.album_select_title, args.title)
         binding.toolbarAlbumSelect.textviewAlbumTitle.run {
             text = SpannableStringBuilder(toolbarTitle).apply {
@@ -68,17 +78,9 @@ class AlbumSelectFragment : BaseFragment<FragmentAlbumSelectBinding>(
                 }
             }
         }
-        if (args.selectedImageInfo.uris.isNotEmpty()) {
-            binding.toolbarAlbumSelect.run {
-                textviewAlbumComplete.isEnabled = true
-                textviewAlbumComplete.setTextColor(ContextCompat.getColor(requireContext(), R.color.black))
-                textviewAlbumCount.text = args.selectedImageInfo.uris.size.toString()
-            }
-        }
-        initCollector()
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.albumInfoEvent.collectLatest {
                 adapter.submitList(it)

diff --git a/...ation/src/main/java/com/fakedevelopers/presentation/ui/productList/ProductListFragment.kt b/...ation/src/main/java/com/fakedevelopers/presentation/ui/productList/ProductListFragment.kt
@@ -56,12 +56,10 @@ class ProductListFragment : BaseFragment<FragmentProductListBinding>(
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         binding.vm = viewModel
-        initListener()
-        initCollector()
         viewModel.initSearchWord(args.searchWord)
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.isRefreshing.collectLatest { state ->
                 binding.swipeProductList.isRefreshing = state
@@ -76,7 +74,7 @@ class ProductListFragment : BaseFragment<FragmentProductListBinding>(
         }
     }
 
-    private fun initListener() {
+    override fun initListener() {
         binding.swipeProductList.setOnRefreshListener {
             viewModel.requestProductList(true)
         }

diff --git a/...n/src/main/java/com/fakedevelopers/presentation/ui/productSearch/ProductSearchFragment.kt b/...n/src/main/java/com/fakedevelopers/presentation/ui/productSearch/ProductSearchFragment.kt
@@ -30,11 +30,9 @@ class ProductSearchFragment : BaseFragment<FragmentProductSearchBinding>(
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         binding.vm = viewModel
-        initCollector()
-        initListener()
     }
 
-    private fun initCollector() {
+    override fun initCollector() {
         repeatOnStarted(viewLifecycleOwner) {
             viewModel.searchWord.collectLatest {
                 findNavController().apply {
@@ -60,7 +58,7 @@ class ProductSearchFragment : BaseFragment<FragmentProductSearchBinding>(
         }
     }
 
-    private fun initListener() {
+    override fun initListener() {
         viewModel.setSearchBar(args.searchWord)
         binding.edittextToolbarSearch.run {
             // 키보드 올리기 전에 포커싱을 줘야함