Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back .Net 4.6 support, can build solution cross-platform #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jzapdot
Copy link

@jzapdot jzapdot commented Nov 22, 2022

This PR contains two things:

  • It reverts the changes committed by Dependabot here (e81d1ac) that removed .Net 4.6 support. This is still needed by Unity as that is the latest .Net Framework level supported.
  • It adds the .Net 4.6 ReferenceAssemblies nuget package to all of the windows projects in the solution. This enables building the solution for this framework level even on machines that do not have the developer packs installed for this version. It particularly helps for macOS and likely Unix machines to be able to build this solution as those framework developer SDKs are not available to install on those platforms.

Together this enables building the solution on macOS and using the output assemblies in a Unity project. For us this fixed an issue using this library from the latest released version 2.3.2 (over two years old).

This reverts commit e81d1ac. .Net 4.6 support is still required for the latest Unity version (2022.1) as of this time and .Net 6 is not available for that engine.
* Modified windows projects to include .Net 4.6 ReferenceAssemblies nuget package. This enables building these projects on platforms where the developer packs for the this framework version
@justonia
Copy link

THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants