Skip to content

Commit

Permalink
Merge pull request #26 from Fabrizz/dev-features
Browse files Browse the repository at this point in the history
QOL | Readme | Vibrant notf
  • Loading branch information
Fabrizz authored Sep 12, 2023
2 parents e188f86 + c9ae2c2 commit d0db7ca
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ updates:
schedule:
interval: "monthly"
ignore:
- dependency-name: "node_fetch"
- dependency-name: "node_fetch" # Allows older node versions to work correctly
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,6 @@ package-lock.json

# Example responeses
ex.json
test.json
api.json

6 changes: 1 addition & 5 deletions MMM-OnSpotify.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Module.register("MMM-OnSpotify", {
this.firstSongOnLoad = true;

///////////////////////
this.version = "2.3.0";
this.version = "2.3.1";
///////////////////////

this.displayUser =
Expand Down Expand Up @@ -206,11 +206,7 @@ Module.register("MMM-OnSpotify", {
// --[ONSP]-[VIBRANT]-[VIBRANT-SCHEME-COLOR]
providerPrefix: "ONSP",
providerScheme: "VIBRANT",
// Lock on [MMM-OnSpotify] until [provider] decides (player is empty)
set: "lock",
until: "provider",
// Override other providers as its an ongoing event
priority: true,
});
this.globalThemeSelected = true;
}
Expand Down
12 changes: 4 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,7 @@ You can show lyrics in a realy nice way using [MMM-LiveLyrics](https://github.co
provider: "MMM-OnSpotify",
providerPrefix: "ONSP",
providerScheme: "VIBRANT",
// CSS VARS: --(ONSP)-(VIBRANT)-(VIBRANT-SCHEME-COLOR]
set: "lock",
until: "provider",
priority: true,
// Lock on [MMM-OnSpotify] until [provider] decides (player is empty)
set: "lock", // CSS token: --ONSP-VIBRANT-[COLOR LABEL]
}

{ /* Player empty */
Expand Down Expand Up @@ -200,7 +196,7 @@ Everytime the player changes states or the song changes, the module sends a noti
```

### `DEVICE_CHANGE` -->
Everytime the device that is set as the output changes, this notification is fired.
Everytime the Spotify Connect target changes, this notification is fired.

```js
{
Expand All @@ -209,11 +205,11 @@ Everytime the device that is set as the output changes, this notification is fir
}
```
### `ONSPOTIFY_NOTICE` -->
Everytime the device that is set as the output changes, this notification is fired.
This notification signals other modules that OnSpotify is available.

```js
{
version: "2.1.0" // Version string
version: "2.3.1" // Version string
directColorData: true // Loads Vibrant
loadsSpotifyCode: true // if it shows Spotify Codes
}
Expand Down
2 changes: 1 addition & 1 deletion node_helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ module.exports = NodeHelper.create({
break;
}
} catch (error) {
console.log(error);
console.error("\x1b[41m%s\x1b[0m", "[MMM-NPOS] [Node Helper] >> ", error);
}
},

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
],
"author": {
"name": "Fabrizz",
"email": "contact@fabriz.co",
"email": "mmmonsp+github@fabriz.co",
"url": "https://fabriz.co/"
},
"bugs": {
Expand Down
7 changes: 5 additions & 2 deletions translations/yourlanguaje.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"NOTHING_PLAYING": "Nothing is playing",
"SPOTIFY_HEADER": "MMM-OnSpotify",
"DEBUG_COLORS": "Debug palettes are shown because <showDebugPalette> is set to true",
"SPOTIFYCODE_EXPERIMENTAL": "<spotifyCodeExperimentalShow> is enabled. The api to generate codes is not public, and can end without prior notice. View more in the readme..."
}
"SPOTIFYCODE_EXPERIMENTAL": "<spotifyCodeExperimentalShow> is enabled. The api to generate codes is not public, and can end without prior notice. (https://github.com/Fabrizz/MMM-OnSpotify#other)",
"RESUME": "Resuming module",
"SUSPEND": "Suspending module",
"LIVELYRICS_NOTICE": "MMM-LiveLyrics found! - Check MMM-LL logs to see more. (https://github.com/Fabrizz/MMM-LiveLyrics)"
}
2 changes: 1 addition & 1 deletion utils/SpotifyDomBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ class SpotifyDomBuilder {
);
this.root.style.setProperty(
"--ONSP-INTERNAL-AFFINITY-TEXT",
"'Connecting to Spotify...'", // translator("STABLISHING_CONNECTION"),
this.translate("STABLISHING_CONNECTION"),
);
});
}
Expand Down
2 changes: 1 addition & 1 deletion vendor/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ Library: https://github.com/Vibrant-Colors/node-vibrant
> Custom build using the pull [#139 from @baoshan](https://github.com/Vibrant-Colors/node-vibrant/pull/139).
Fixes Webworker thread usage so the color proccessing does not affect painting.

> If you want to build it yourself or use other version and you are using a newer node.js version (<17.0) set `$env:NODE_OPTIONS="--openssl-legacy-provider"` to use the legacy ossl
> If you want to build it yourself or use other version and you are using a newer node.js version (<17.0) set `$env:NODE_OPTIONS="--openssl-legacy-provider"` to use the legacy OSSL

0 comments on commit d0db7ca

Please sign in to comment.