Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update add method for StatType in TranslationBuilder #4143

Open
wants to merge 2 commits into
base: 1.21.1
Choose a base branch
from
Open

Update add method for StatType in TranslationBuilder #4143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ac31b
Use translation key from name element, with fallback to Util.createTr…
solonovamax Oct 5, 2024
9339092
Fix spotless issues
solonovamax Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...-v1/src/main/java/net/fabricmc/fabric/api/datagen/v1/provider/FabricLanguageProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,11 @@ default void add(RegistryEntry<EntityAttribute> entityAttribute, String value) {
* @param value The value of the entry.
*/
default void add(StatType<?> statType, String value) {
add("stat_type." + Registries.STAT_TYPE.getId(statType).toString().replace(':', '.'), value);
if (statType.getName() instanceof TranslatableTextContent translatableTextContent) {
add(translatableTextContent.getKey(), value);
} else { // fallback to Util.createTranslationKey formatting (should it error instead?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error? not sure how the translation would be used if the name is not TTC.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just threw in a fallback because you never know, some person might try and have like some string literal concatenated with the translation. But I can always make it an error.

add(Util.createTranslationKey("stat_type", Registries.STAT_TYPE.getId(statType)), value);
}
}

/**
Expand Down
Loading