Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod to Minecraft snapshot 24w40a #4136

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

haykam821
Copy link
Contributor

@haykam821 haykam821 commented Oct 2, 2024

This pull request ports Fabric API to Minecraft snapshot 24w40a without any breaking changes.

In addition, the c:is_dark_forest biome tag has been added. This biome tag includes the dark forest and pale garden biomes, as the latter is a variant of the former, as stated by the Minecraft changelog:

Pale Garden

Pale Garden is a biome variation of Dark Forest.

The game runs, but when creating a new world after exiting another world, the game may crash with the message Caused by: java.lang.IllegalStateException: Tags already captured, this should not happen.

@haykam821 haykam821 marked this pull request as draft October 2, 2024 18:37
@modmuss50 modmuss50 self-assigned this Oct 2, 2024
@modmuss50 modmuss50 added port Porting existing code to a different version priority:high High priority PRs that need review and work now. Review these first. labels Oct 2, 2024
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I cannot reproduce the crash, im happy to release it as-is. The recipe stuff can be improved over the coming weeks.

@haykam821
Copy link
Contributor Author

I can try to reproduce the crash again later. The only differences I can think of that my environment may have is worlds with feature flags enabled and the test worlds from #4118.

I do realize that the pale oak chest boat is missing from the c:boats tag; that (and probably #4135) should be fixed as well.

@modmuss50 modmuss50 linked an issue Oct 2, 2024 that may be closed by this pull request
@modmuss50
Copy link
Member

I do realize that the pale oak chest boat is missing from the c:boats tag; that (and probably #4135) should be fixed as well.

Fixed both, thanks.

I have tried worlds with the experiments enabled and all seems fine. Ill release this now and we can always fix the crash later.

@modmuss50 modmuss50 marked this pull request as ready for review October 2, 2024 19:25
@modmuss50 modmuss50 merged commit 86ae0e5 into FabricMC:1.21.2 Oct 2, 2024
4 checks passed
@haykam821 haykam821 deleted the update-24w40a branch October 3, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port Porting existing code to a different version priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dyed bundles are not in the respective dyed tags
2 participants