some fixes

FZJ-IEK3-VSA · Oct 23, 2024 · 8c1a19a · 8c1a19a
1 parent 798801b
commit 8c1a19a
Show file tree

Hide file tree

Showing 4 changed files with 1,293 additions and 762 deletions.
diff --git a/hisim/components/advanced_fuel_cell.py b/hisim/components/advanced_fuel_cell.py
@@ -568,7 +568,7 @@ def i_simulate(self, timestep: int, stsv: SingleTimeStepValues, force_convergenc
         else:
             if self.gas_type == "Hydrogen":
                 gas_demand_target = ((el_power / eff_el_real) + (th_power / eff_th_real)) / (
-                    PhysicsConfig.hydrogen_specific_fuel_value_per_kg
+                    PhysicsConfig.get_properties_for_energy_carrier(energy_carrier=lt.LoadTypes.HYDROGEN).lower_heating_value_in_joule_per_kg
                 )
                 if stsv.get_input_value(self.hydrogen_not_released_channel) == 0:
                     # Gas Demand can completly be charged from storage
@@ -598,7 +598,7 @@ def i_simulate(self, timestep: int, stsv: SingleTimeStepValues, force_convergenc
             elif self.gas_type == "Methan":
                 gas_demand_target = (
                     (el_power / eff_el_real) + (th_power / eff_th_real)
-                ) / PhysicsConfig.natural_gas_specific_fuel_value_per_kg
+                ) / PhysicsConfig.get_properties_for_energy_carrier(energy_carrier=lt.LoadTypes.GAS).lower_heating_value_in_joule_per_kg
                 gas_demand_real_used = gas_demand_target
             else:
                 raise Exception("No Gas chosen which is integrated in System")