-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghost functions have a model supporting their erasure #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stconditions on freshness
nikswamy
commented
Feb 29, 2024
@@ -187,7 +187,7 @@ let lift_ghost_neutral | |||
(e:stt_ghost a pre post) | |||
(reveal_a:non_informative_witness a) | |||
: stt_atomic a #Neutral emp_inames pre post | |||
= admit() //This is the main axiom about ghost computations; in Steel, this axiom is implemented within the effect system | |||
= Action.lift_erased reveal_a e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main payoff
nikswamy
commented
Feb 29, 2024
#Unobservable emp_inames | ||
(ghost_pts_to r v) | ||
(fun v1 -> ghost_pts_to r v ** pure (fact v1)) | ||
// Unused? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are unused, but @mtzguido tells me that they are expected to be required soon. I will restore them in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PulseCore, Ghost functions were previously not semantically distinguished from other atomic .actions, although they were marked as erased. This meant that we needed an axiom to lift ghost functions (with non-informative results) to regular actions. With this PR, we no longer need that axiom.
The technical mechanism enabling this is to move to a bipartite heap PulseCore.Heap2, consisting of a concrete heap and a ghost erased heap. Ghost functions are proven to only mutate the erased heap, and ghost functions now have a model starting from Heap2 and going up through Memory, Action, and Atomic layers.
Note, although this led to removing the axiom, the proofs require quite a lot of boilerplate and duplication between the concrete and ghost heaps. Expect a follow-up PR trying to add some abstraction there to reduce the boilerplate.