Make axclient nice to use #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought about having this be its own git repository but the actionlib_tools from ROS has not been updated in 2 years and it seems they have no intention of doing so. Would be cool to merge our version to the main ros repo though. |
Even so, let's do it the right way so we don't have to fix it later on
You could submit a PR, worst case they just ignore it? |
|
Added to rosinstall. I had actually already made a PR here hopefully they accept and then we can say we have contributed to ROS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to do this for a while but finally decided to somewhat rewrite axclient to support multiple actions and not require the user to give the path to the action. Code will never be run on the robot (hopefully) but I think it should make debugging actionlib servers a lot nicer. Also brings up the raw message files to make enums and comments easier. Tested in sim, works with hold position and other actionlib servers.
