Create Launch Subsystem with Solenoid #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser-frc
reviewed
Jan 25, 2024
| public Launcher() { | ||
| SmartDashboard.putNumber("Launch P", upper.getPIDController().getP()); | ||
| SmartDashboard.putNumber("Launch I", upper.getPIDController().getI()); | ||
| SmartDashboard.putNumber("Launch D", upper.getPIDController().getD()); |
There was a problem hiding this comment.
I don't think you ever set the pid vaules unless you are in tuningPIDs mode.
smoser-frc
reviewed
Jan 25, 2024
There was a problem hiding this comment.
one comment in-line.
Second overall comment. Here you chose to use the CANSparkMax builtin pid controller, which in theory should have better resolution and response time.
Could you try it with just PIDController from WPILIB?
The reason I'm asking is that may give you the option to tune PID in the test mode like described here with a nice widget rather than lots and lots of smart dashboard boxes .
the
|
This is superceded by the other later #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.