Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add FLAMEGPU_SEATBELTS=OFF CI via matrix include: #1138

Merged
merged 2 commits into from
Nov 1, 2023
Merged

CI: Add FLAMEGPU_SEATBELTS=OFF CI via matrix include: #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06d098
CI: Add FLAMEGPU_SEATBELTS=OFF CI to the ubuntu and windows regular w…
ptheywood Oct 27, 2023
6525577
Reduce the number of CI builds which do the individual example
ptheywood Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/Ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,30 @@ jobs:
- name: "Release"
config: "Release"
SEATBELTS: "ON"
- name: "Beltsoff"
config: "Release"
SEATBELTS: "OFF"
VISUALISATION:
- "ON"
- "OFF"

exclude:
# Exclude VIS=ON for old cuda's.
# Exclude VIS=ON for oldest cuda.
- cudacxx:
cuda: "11.0"
VISUALISATION: "ON"
# Exclude beltsoff builds for old cuda's
- cudacxx:
cuda: "11.8"
config:
name: "Beltsoff"
- cudacxx:
cuda: "11.0"
config:
name: "Beltsoff"
# Exclude beltsoff vis builds to keep the matrix lighter.
- config:
name: "Beltsoff"
VISUALISATION: "ON"

# Name the job based on matrix/env options
name: "build (${{ matrix.cudacxx.cuda }}, ${{matrix.python}}, ${{ matrix.VISUALISATION }}, ${{ matrix.config.name }}, ${{ matrix.cudacxx.os }})"
Expand All @@ -64,7 +79,7 @@ jobs:
env:
# Workflow specific constants for building a specific example
# Note this assumes the example exists in cpp, rather than cpp_rtc subdirectory
INDIVIDUAL_EXAMPLE: "game_of_life"
INDIVIDUAL_EXAMPLE: ${{ fromJSON('{true:"game_of_life",false:""}')[matrix.config.name == 'Release' && matrix.VISUALISATION == 'OFF'] }}
# Define constants
BUILD_DIR: "build"
FLAMEGPU_BUILD_TESTS: "ON"
Expand Down Expand Up @@ -164,6 +179,7 @@ jobs:
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DFLAMEGPU_BUILD_TESTS="${{ env.FLAMEGPU_BUILD_TESTS }}"
-DFLAMEGPU_BUILD_PYTHON="${{ env.FLAMEGPU_BUILD_PYTHON }}"
-DPYTHON3_EXACT_VERSION="${{ env.PYTHON }}"
Expand Down Expand Up @@ -197,9 +213,10 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_VISUALISATION="${{ env.VISUALISATION }}"
-DFLAMEGPU_ENABLE_NVTX="ON"
-DFLAMEGPU_SEATBELTS="OFF"

- name: Build Individual example
if: ${{ env.INDIVIDUAL_EXAMPLE != '' }}
Expand Down
26 changes: 22 additions & 4 deletions .github/workflows/Windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,30 @@ jobs:
- name: "Release"
config: "Release"
SEATBELTS: "ON"
- name: "Beltsoff"
config: "Release"
SEATBELTS: "OFF"
VISUALISATION:
- "ON"
- "OFF"

exclude:
# Exclude VIS=ON for old cuda's.
# Exclude VIS=ON for oldest cuda.
- cudacxx:
cuda: "11.0.3"
VISUALISATION: "ON"
# Exclude beltsoff builds for old cuda's
- cudacxx:
cuda: "11.8.0"
config:
name: "Beltsoff"
- cudacxx:
cuda: "11.0.3"
config:
name: "Beltsoff"
# Exclude beltsoff vis builds to keep the matrix lighter.
- config:
name: "Beltsoff"
VISUALISATION: "ON"

# Name the job based on matrix/env options
name: "build (${{ matrix.cudacxx.cuda }}, ${{matrix.python}}, ${{ matrix.VISUALISATION }}, ${{ matrix.config.name }}, ${{ matrix.cudacxx.os }})"
Expand All @@ -64,7 +79,8 @@ jobs:
env:
# Workflow specific constants for building a specific example
# Note this assumes the example exists in cpp, rather than cpp_rtc subdirectory
INDIVIDUAL_EXAMPLE: "game_of_life"
# The individual example is only built for some built matrices, to spend less time in CI.
INDIVIDUAL_EXAMPLE: ${{ fromJSON('{true:"game_of_life",false:""}')[matrix.config.name == 'Release' && matrix.VISUALISATION == 'OFF'] }}
# Compute the wheelhouse name which should be unique within the matrix. This must be unique per build matrix/job combination
ARTIFACT_NAME: wheel-windows-${{ matrix.cudacxx.cuda }}-${{matrix.python}}-${{ matrix.VISUALISATION }}-${{ matrix.config.name }}-${{ matrix.cudacxx.os }}
# Define constants
Expand Down Expand Up @@ -121,6 +137,7 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_BUILD_TESTS="${{ env.FLAMEGPU_BUILD_TESTS }}"
-DFLAMEGPU_BUILD_PYTHON="${{ env.FLAMEGPU_BUILD_PYTHON }}"
Expand Down Expand Up @@ -167,9 +184,10 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_VISUALISATION="${{ env.VISUALISATION }}"
-DFLAMEGPU_ENABLE_NVTX="ON"
-DFLAMEGPU_SEATBELTS="OFF"

- name: Build Individual example
if: ${{ env.INDIVIDUAL_EXAMPLE != '' }}
Expand Down