CMake: Fix source_group use when fetched via CMake Fetch Content #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of FLAMEGPU_ROOT Due to the dynamic version.cpp file, which is placed in the build directory, source_group TREE could fail when the build directory was not a child of FLAMEGPU_ROOT. I.e. when FLAMEGPU/FLAMEGPU2 is fetched via CMake FetchContent. This applies similar filtering to examples, where source_group(TREE) is only used when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake: Fix new FLAMEGPU source_group rules when build is not a child of FLAMEGPU_ROOT
Due to the dynamic version.cpp file, which is placed in the build directory, source_group TREE could fail when the build directory was not a child of FLAMEGPU_ROOT. I.e. when FLAMEGPU/FLAMEGPU2 is fetched via CMake FetchContent.
This applies similar filtering to examples, where source_group(TREE) is only used when appropriate.
Manually tested on windows, with FLAMEGPU/FLAMEGPU2 and FLAMEGPU/FLAMEGPU2-model-template-cpp