Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed Ensembles (MPI) #156

Merged
merged 8 commits into from
Dec 16, 2023
Merged

Distributed Ensembles (MPI) #156

merged 8 commits into from
Dec 16, 2023

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Jul 26, 2023 •
edited
Loading

Also clarify CUDAEnsemble::getLogs() now returns std::map

@Robadob Robadob added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 26, 2023
@Robadob Robadob self-assigned this Jul 26, 2023
@Robadob Robadob mentioned this pull request Jul 26, 2023
Merged
11 tasks
@Robadob Robadob force-pushed the distributed_ensemble branch 3 times, most recently from 3893cdb to 1eac4bc Compare July 26, 2023 12:35
@Robadob Robadob marked this pull request as ready for review July 26, 2023 15:09
ptheywood
ptheywood requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required, but worth waiting till after the actual PR is reviewed and is ready to go, as it may impact what the changes should be

src/guide/running-multiple-simulations/index.rst Outdated Show resolved Hide resolved
src/guide/running-multiple-simulations/index.rst Outdated Show resolved Hide resolved
src/guide/running-multiple-simulations/index.rst Outdated Show resolved Hide resolved
src/guide/running-multiple-simulations/index.rst Outdated Show resolved Hide resolved
src/guide/running-multiple-simulations/index.rst Outdated Show resolved Hide resolved
src/guide/running-multiple-simulations/index.rst Show resolved Hide resolved
@Robadob
Distributed Ensembles (MPI)
991066d 
Also clarify CUDAEnsemble::getLogs() now returns std::map
@Robadob
Address cleanup() and cuda-aware MPI
fb9e548
mondus
mondus previously requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@mondus mondus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires some documentation showing the mpirun command for the new MPI test suite.

ptheywood
ptheywood approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reflect changes in the feature.

@Robadob worth a quick look at my latest changes to double-check me (though you won't be able to approve/request changes yourself?)

@ptheywood ptheywood merged commit 7cb57eb into master Dec 16, 2023
5 checks passed
@ptheywood ptheywood deleted the distributed_ensemble branch December 16, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptheywood ptheywood ptheywood approved these changes

@mondus mondus Awaiting requested review from mondus

Assignees

@Robadob Robadob

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robadob @ptheywood @mondus