Improved url selection #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHachez
reviewed
Oct 22, 2024
| const cursor = editor.getCursor(); | ||
| const line = editor.getLine(cursor.line); | ||
|
|
||
| const youtubeRegex = /https?:\/\/(?:www\.)?(?:youtube\.com\/watch\?v=|youtu\.be\/)([a-zA-Z0-9_-]+)(?:&\S*)?/; |
There was a problem hiding this comment.
Can you make sure that we detect any url? The goal is to support other urls than youtube, for example twitter etc.
|
Thank you @tbrams for this PR and updating the dependencies. It's a good point that it's too difficult to activate, since you need to select precisely the URL. It's a nice idea to use Can you make sure that this works with other URLs than YouTube? For example, we could rework the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for providing this very useful plugin ^^
When I started using it though, I wondered why it never gave me the option to activate it using the right click menu, and even after defining a hotkey, I had to manually select the entire url to make it do something. For me, that seemed like an unnecessary effort...
For that reason, I have made the small improvement that if the cursor is placed in, or next to, a valid youtube url, the urlwill automatically be selected and replaced by the iframe generated by your plugin.