linux: avoid using CLOCK_SGI_CYCLE #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call clock_gettime(CLOCK_SGI_CYCLE, &t) from function getticks() fails with EINVAL. See : http://elixir.free-electrons.com/linux/latest/source/include/uapi/linux/time.h#L62 - "The driver implementing this got removed. The clock ID is kept as a place holder. Do not reuse!"
soundart
referenced
this pull request
Jan 5, 2018
The Android headers defines CLOCK_SGI_CYCLE but the call fails at runtime as it's not implemented. Combined with getticks() not checking the return value of clock_gettime() this causes bogus values to be returned from getticks().
|
Hi I updated the patch, because:
|
|
Hi, yes I think too, but it is difficult to judge without an android build for testing. I guess the android build uses one of these: #if defined(HAVE_ARMV7A_CNTVCT) and I think these defines should move upwards in cycle.h, so that they appear before the more generic clock_gettime() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call clock_gettime(CLOCK_SGI_CYCLE, &t) from function getticks() fails with EINVAL.
See : http://elixir.free-electrons.com/linux/latest/source/include/uapi/linux/time.h#L62 - "The driver implementing this got removed. The clock ID is kept as a place holder. Do not reuse!"
See #122