Fix num_entities by using explicit math formula for counting #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createyourpersonalaccount
force-pushed
the
fix-num_entities
branch
from
432a916
to
a1a840e
Compare
createyourpersonalaccount
force-pushed
the
fix-num_entities
branch
from
a1a840e
to
2e273d7
Compare
|
cc @chrisrichardson. FYI, @createyourpersonalaccount is doing a GSOC project with Debian. @createyourpersonalaccount , it would be good if you could modify the message in the first post adding a couple of sentences on what motivated you to propose this PR, so that anyone who will find this PR in future will be able to remember what the rationale was. |
|
@francesco-ballarin I edited the original PR message to include some information. |
chrisrichardson
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the source code searching for issues with some crashes I have with this software (I still haven't figured out why there's crashes but I've noticed that under gdb I can no longer obtain them, which means they're sensitive to timing, I think) I noticed this cell-counting function was doing some unnecessary work; I simplified it with the right formula.