Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTKHDF mesh I/O #3576

Merged
merged 14 commits into from
Dec 27, 2024
Merged

VTKHDF mesh I/O #3576

merged 14 commits into from
Dec 27, 2024

Conversation

chrisrichardson
Copy link
Contributor

@chrisrichardson chrisrichardson commented Dec 24, 2024

Adds a simple reader and writer for Mesh using the VTKHDF format.
This is currently limited to first order meshes (but can be extended to higher order).
Includes support for mixed-topology meshes.

  • Add float32 support in Python layer
  • Add Python wrapper
  • Add mixed-topology test fixture

@jorgensd
Copy link
Member

jorgensd commented Dec 24, 2024

Why have you chosen to restrict it to first order meshes (the restriction is not present in my Python implementation)

@chrisrichardson
Copy link
Contributor Author

@jorgensd - partly because higher order pyramids are not working in Paraview, partly just to keep it simpler for now.
I noted above that it can be an extension...

@jorgensd
Copy link
Member

@jorgensd - partly because higher order pyramids are not working in Paraview, partly just to keep it simpler for now. I noted above that it can be an extension...

I really think we should include higher order right away.
XDMF only supports second order grids. Thus we have no API for reading in higher order meshes that are not generated through GMSH (max degree 3).

very few (if any uses pyramids atm, especially higher order ones, and if the issue is with Paraview it shouldn’t limit us).

@jorgensd
Copy link
Member

Additionally, the code complexity for higher order is not really hard (as shown in the mixed topology io branch with the Python implementation).

@garth-wells garth-wells added enhancement New feature or request io labels Dec 26, 2024
@chrisrichardson chrisrichardson marked this pull request as ready for review December 27, 2024 10:11
@chrisrichardson chrisrichardson added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit ac552c4 Dec 27, 2024
34 checks passed
@chrisrichardson chrisrichardson deleted the chris/vtkhdf-writer branch December 27, 2024 23:21
schnellerhase pushed a commit to schnellerhase/dolfinx that referenced this pull request Dec 28, 2024
* Work in progress

* Work in progress

* Reorganise

* tidy

* Add comments and test

* Interface update

* Work on Python layer

* Add docstrings

* Add mixed mesh fixture

* fix?

* Add typing

---------

Co-authored-by: Garth N. Wells <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants