Make read_meshtags a template function #3533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleoni-pf
changed the title
mleoni-pf
changed the title
garth-wells
reviewed
Nov 28, 2024
| read_meshtags(const mesh::Mesh<double>& mesh, std::string name, | ||
| std::optional<std::string> attribute_name, | ||
| std::string xpath = "/Xdmf/Domain"); | ||
| template <typename T = std::int32_t> |
There was a problem hiding this comment.
What types are supported? If the type in the file can't be checked it can lead to all sorts of crashes and mis-behaviours.
What is needed for this to be robust is a function for querying the data type in the file. I started this ages ago for HDF5 files, but it wasn't trivial to make it precise, but getting the type size was easy and may be adequate.
There was a problem hiding this comment.
We hit the same issue with the recent checkpointing project. We should have a chat in #developmemt about the best ways to tackle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages functionalities introduced some time ago by @jorgensd that makes
xdmf_utils::distribute_entity_dataprocess data of a generic type, not onlystd::int32_t. In this PR I makeXDMFFile::read_meshtagsa template so that we can read mesh tags of any type [esp.double] from file. This will be useful in an upcoming PR to read functions from file.