Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value to classify entry #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hesingh
Copy link
Contributor

@hesingh hesingh commented Jan 19, 2021

The VPP bihash supports a key-value pair to provision an entry for a table. For example, see

https://github.com/FDio/vpp/blob/master/src/vppinfra/bihash_48_8.h#L39

However, the VPP classifier entry does not support a value. This PR adds a u64 value to the classifier entry.

The use case is the following value for my 5G UPF on matching a classifier entry. Current classifier code with its opaque_index node and metadata cannot support my value.

struct pkt_filter4_0_value {
    enum pkt_filter4_0_actions action;
    union {
        struct {
        } drop4;
        struct {
            uint8_t abits;
            uint16_t ig_strip;
            uint16_t outer_desc;
            uint32_t teid;
            uint32_t ip;
            uint32_t src_ip;
            uint16_t dstPort;
            uint8_t filt_dir;
            uint8_t reflec_qos;
        } permit4;
        struct {
            uint8_t abits;
            uint16_t ig_strip;
            uint64_t srcAddr;
            uint64_t dstAddr;
            uint16_t etherType;
        } add_eth4;
    } u;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant