-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Multiformat Reader - Witec and ROD #16
Conversation
I want to update later the .rod file parser, to include all available meta data - with a seperate PR. |
I have now included the config files as well wihtin the tests. Would be better if they are only at one location. Maybe I can remove then the config folder in source? As this config file is spcified for the respective example, it may be better to place it there? |
The point of having it in src/ is that you don't need to always use it as an input file to the reader. If you remove it from there, you e.g. always have to drop it to NOMAD. I thought the rod data has always the same structure? Then it makes sense to have a config as default. You can always drop another config file that takes priority over the default. By the way, when I remove the config file in tests/data/rod, the tests still work. But not so for removing it from tests/data/witec |
@lukaspie "By the way, when I remove the config file in tests/data/rod, the tests still work. But not so for removing it from tests/data/witec" Hm okay? Ill try to take a look into it. Weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments here and there, but overall looks okay for me now. Please also update the name and description of the PR for future reference.
Somehow, something unknown broke the the CI/CD broke with the first PR version. Here a new PR:
First version to add the Raman Open Database File reader.
Tasks