Add structured configs to hydra cli, pass cfg to runners #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbluque
approved these changes
Jan 21, 2025
src/fairchem/core/_cli_hydra.py
Outdated
Comment on lines
66
to
73
| class FairchemJobConfig: | ||
| run_name: str = field(default_factory=lambda: uuid.uuid4().hex.upper()[0:8]) | ||
| timestamp_id: str = field(default_factory=lambda: get_timestamp_uid()) | ||
| run_dir: str = field(default_factory=lambda: tempfile.TemporaryDirectory().name) | ||
| log_dir: str = "logs" | ||
| device_type: DeviceType = DeviceType.CUDA | ||
| debug: bool = False | ||
| scheduler: SchedulerConfig = field(default_factory=lambda: SchedulerConfig) |
There was a problem hiding this comment.
The current trainer records the commit hash + version being used. Would be nice to keep that. (We technically only need the commit hash since the version has it, but no harm in keeping both)
fairchem/src/fairchem/core/trainers/base_trainer.py
Lines 142 to 143 in c162617
There was a problem hiding this comment.
let me think about where to log these, we should retain these tho they arent exactly input config params
Codecov ReportAttention: Patch coverage is
|
lbluque
requested changes
Jan 22, 2025
| @@ -31,6 +44,7 @@ def __init__(self, x: int, y: int): | |||
| self.y = y | |||
|
|
|||
| def run(self) -> Any: | |||
| assert hasattr(self, "fairchem_config") | |||
There was a problem hiding this comment.
Is this assert ever false? seems superfluous using @property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cli will be called like:
fairchemv2 --config-yml /path/to/yaml [hydra-like config overides]This removes the old arg flags completely and moves them into FairchemJobConfig as a structured config:
Users are free to specify the either in the yaml or in the command line as they choose
in yaml:
in command line:
fairchemv2 --config-yml /path/to/yaml +job.scheduler.num_ranks_per_node=4ie: runner.fairchem_config