OCPCalculator output_only option #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
misko
force-pushed
the
add_calculator_only_output_field
branch
from
ff7b366 to
e2c1787
Compare
fix lint undo change to packages undo change to packages
misko
force-pushed
the
add_calculator_only_output_field
branch
from
e2c1787 to
5e3ee75
Compare
lbluque
requested changes
Dec 3, 2024
| only_output, list | ||
| ), "only output must be a list of targets to output" | ||
| for key in only_output: | ||
| assert ( |
| @@ -80,6 +80,7 @@ def __init__( | |||
| max_neighbors: int = 50, | |||
| cpu: bool = True, | |||
| seed: int | None = None, | |||
| only_output: list[str] | None = None, | |||
There was a problem hiding this comment.
nit, better to have only_output as a tuple, since its not meant to be changed at all in the code
lbluque
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
misko
added a commit
that referenced
this pull request
Jan 17, 2025
fix lint undo change to packages undo change to packages Co-authored-by: Luis Barroso-Luque <[email protected]> Former-commit-id: 3ed7a2142dee24494a8c2c0e7251a4a5ba8d3b31
beomseok-kang
pushed a commit
to beomseok-kang/fairchem
that referenced
this pull request
Jan 27, 2025
) fix lint undo change to packages undo change to packages Co-authored-by: Luis Barroso-Luque <[email protected]> Former-commit-id: 7a32302ac1427cf87dcbc2d69001d66345a2fcdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our publicly available models have an internal config that lists output tasks that dont exist in the model. One example is "PaiNN-IS2RE-OC20-All"
We could patch each checkpoint, but instead we could also add an output_only field to our calculator, which is what this does. Additionally also adds tests for this.