Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getting game/replay id from /savereplay cmd argument #3226

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Fixed getting game/replay id from /savereplay cmd argument #3226

merged 1 commit into from
Dec 27, 2020

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Nov 29, 2020

This is the port of fixes FA-mods/SupremeScoreBoard#20.

Previously /savereplay cmd arg had a format of gpgnet://localhost/uid/username.SCFAreplay, but in FAForever/downlords-faf-client@1ae6c7e#diff-3d47503b30b47f5a259049a2e45e1eb555b502bd1f9cc68c936394a0d8fc6f1fR192 it has been changed to gpgnet://localIp:localReplayPort/uid/username.SCFAreplay, what leads a bug when in the ID text in score board instead of replayid there is local replay port ("magic number" 20 in string.find(url, "/", 20) and string.sub(url, 20, lastpos-1) is for length of gpgnet://localhost/) ¯_(ツ)_/¯

This PR fixes this bug.

@shalkya
Copy link
Member

shalkya commented Dec 27, 2020

merging it to see how it works directly in deploy/fafdevelop

@shalkya shalkya merged commit 492a22c into FAForever:deploy/fafdevelop Dec 27, 2020
@timocov timocov deleted the fix-game-id branch December 27, 2020 12:17
@shalkya
Copy link
Member

shalkya commented Dec 27, 2020

alright i'm not completely sure of what it fixes :
that's what i'm getting ingame :
image
this is what i'm getting when reading the local replay :
image

this behaviour is exactly the same than in current game

@shalkya shalkya added this to the 3719 milestone Dec 27, 2020
@timocov
Copy link
Contributor Author

timocov commented Dec 27, 2020

@shalkya Isn't SSB on your screenshots instead of built-in score board?

@shalkya
Copy link
Member

shalkya commented Dec 27, 2020

Alright i thought it was a fix with SSB too. All good.

@timocov
Copy link
Contributor Author

timocov commented Dec 27, 2020

I meant, if you'd like to test the fix for SSB, I guess you need to apply patch from SSB repo instead of this one.

Frankly I didn't test the fix with built-in score board, I just found a copy-paste from SSB and apply the fix here (I hope it was copy-paste, not sure what's the source actually).

I guess it should fix the following field and show a replay id instead of local port:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants