Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mute participant #265

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Feat/mute participant #265

merged 6 commits into from
Jan 13, 2025

Conversation

malmen237
Copy link
Contributor

What does this do?

Mute other participant

A mute button is added to the user-list that triggers a message to that participant, if it is active. When the message is received that sets the user's mic to mute. It is then reseted when the user unmutes it's microphone.

Screenshot 2025-01-09 at 10 27 59

Confirmation modal

To mute a participant the user has to click on a confirm button, that informs that the audio will be turned of for the entire call and not only for yourself.

Screenshot 2025-01-09 at 09 42 25

@martinstark
Copy link
Collaborator

martinstark commented Jan 9, 2025

This comment should not affect this PR! Just want to get this down in writing since it's been talked about previously: during the original project we discussed creating something like a "Admin Panel" for a call, where an admin-type user (or anyone) could go to change the settings for everyone in the call, things like:

  • mute / unmute user (for everyone)
  • change user volume by updating their local input volume (for everyone, using custom message + Audio Context GainNode)
  • kick user

I kind of like the idea of having settings like these on a separate panel, so that the buttons are not immediately accessible to everyone

@malmen237 malmen237 linked an issue Jan 9, 2025 that may be closed by this pull request
@malmen237 malmen237 merged commit adf129c into development Jan 13, 2025
3 checks passed
@malmen237 malmen237 deleted the feat/mute-participant branch January 13, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to mute a participant
4 participants