Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: can specify S3 endpoint URL #9

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: can specify S3 endpoint URL #9

merged 2 commits into from
Nov 19, 2024

Conversation

birme
Copy link
Contributor

@birme birme commented Nov 17, 2024

This PR enables configuration of S3 Endpoint URL when package output is an S3 bucket not on AWS

@birme birme requested a review from grusell November 17, 2024 22:17
Copy link
Collaborator

@grusell grusell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme birme merged commit 6a4293d into main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants