Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logo size #85

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/logo size #85

wants to merge 3 commits into from

Conversation

awesomejerry
Copy link
Contributor

No description provided.

@renatobenks
Copy link

renatobenks commented Feb 20, 2020

hey @awesomejerry what else is missing to move forward with this and merge it?

@awesomejerry
Copy link
Contributor Author

Nothing really. Just not sure if it's a needed feature for this library though. What do you think? Is it a must-have feature?

@AzzouQ AzzouQ mentioned this pull request Apr 30, 2020
@AzzouQ
Copy link

AzzouQ commented Apr 30, 2020

@awesomejerry You should also add TS definition, I think that logoSize?: number | {width: number, height: number}; in index.d.ts should do it ? It will allow us to render not square logo with this PR. Great work.

@michaelyiu
Copy link

would love to see this merged as this is the exact case im looking for this package @awesomejerry if you're still maintaining it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants