Provide a way to manage GH issue owner #166
Conversation
| @@ -10,7 +10,12 @@ let octokit; | |||
| */ | |||
| function getOctokit() { | |||
| if (!octokit) { | |||
| octokit = new Octokit({auth: Preferences.getGitHubToken()}); | |||
| /* eslint-disable-next-line no-console */ | |||
| console.log('authenticate with auth token', Preferences.getGitHubToken()); | |||
There was a problem hiding this comment.
I was running into a lot of issues when testing this where I kept hitting a secondary rate limit. I added this log to hopefully help trouble-shoot if it happens in production.
There was a problem hiding this comment.
It was bugging me a little that the buttons weren't aligned with the rest of the pannel...
...so I did a little tinkering and here's a code change that will fix it:
diff --git a/src/css/content.scss b/src/css/content.scss
index f381e0d7..c2fbb01d 100644
--- a/src/css/content.scss
+++ b/src/css/content.scss
@@ -545,9 +545,17 @@ $color-dark-yellow: #DAA520;
top: 60px;
}
-.js-issue-assignees .k2-button {
- position: absolute;
- left: 106%;
+.js-issue-assignees {
+ .js-hovercard-left {
+ position: relative;
+ }
+
+ .k2-button {
+ right: 0;
+ padding: 0;
+ max-height: 100%;
+ position: absolute;
+ }
}
.alert {
Not going to block on it, since it works great
src/js/lib/pages/github/issue.js
Outdated
| const ghDescription = response.data.body; | ||
| const newDescription = `${ghDescription} | ||
|
|
||
| Current Issue Owner: @${owner}`; |
There was a problem hiding this comment.
NAB Should we put this inside a <details> block so it's more obvious that editing it could have unintended side-effects?
There was a problem hiding this comment.
I asked about that in the Slack thread and no one seemed to interested in it. I don't mind putting it in one though if you think it would be helpful.
There was a problem hiding this comment.
Oh I should have specified 🤦♂️ I think the main value in using a details block is that it's collapsable if there's extra text telling the user not to edit the value. Just putting it inside the details block with no other info doesn't seem that useful. I realize though that this suggestion is solving a problem we don't really have, so that's my bad.
There was a problem hiding this comment.
Oh got it, I missed this comment before merging. I actually think it's fine if someone chooses to manually edit it to change the person. It could be that not everyone is using the k2 extension.
|
Updated to move button and put code in |
|
I'm going to merge this, but I'll hold off deploying this until the web-e stuff is in place. |
|
The Web-E PR is https://github.com/Expensify/Web-Expensify/pull/39242 |
This PR adds a small UI to the assignees section of a GH issue to manage the owner of an issue. It will only appear when there are multiple assignees.
It also surfaces the owner information in the K2 dashboard so you can easily see the issues you are the owner of. It puts them at the top of the list and puts the yellow star next to them.