Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include react-native-onyx issues in K2 #131

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Include react-native-onyx issues in K2 #131

merged 2 commits into from
Dec 20, 2022

Conversation

arosiclair
Copy link
Contributor

@arosiclair arosiclair commented Dec 13, 2022 •
edited
Loading

Adds Expensify/react-native-onyx to issue query for the dashboard

Issue
$ https://github.com/Expensify/Expensify/issues/245594

Test

  1. Assigned myself to a react-native-onyx issue (this one).
  2. Verified it shows up in the dashboard at https://github.com/Expensify/Expensify#k2

@arosiclair arosiclair self-assigned this Dec 13, 2022
@arosiclair arosiclair marked this pull request as ready for review December 13, 2022 22:20
@arosiclair arosiclair requested a review from a team December 13, 2022 22:20
@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team December 13, 2022 22:20
@arosiclair
Copy link
Contributor Author

bump @joelbettner

@arosiclair arosiclair requested a review from a team December 20, 2022 15:07
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team December 20, 2022 15:08
@arosiclair
Copy link
Contributor Author

@deetergp you mind giving this a review?

joelbettner
joelbettner approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@joelbettner joelbettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

deetergp
deetergp approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deetergp deetergp merged commit 5dd56e3 into main Dec 20, 2022
@deetergp deetergp deleted the arosiclair-onyx-issues branch December 20, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

@joelbettner joelbettner joelbettner approved these changes

Assignees

@arosiclair arosiclair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arosiclair @deetergp @joelbettner