Skip to content

Commit

Permalink
fix: package.json & package-lock.json to reduce vulnerabilities
Browse files Browse the repository at this point in the history
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Allow single assignees to be starred

Show an empty start when you aren't the owner

Bump version

Add a filter

Bump node and onyx versions

Update setup-node GH action to support node-version-file syntax

Update node version for QSP

Check every second to redraw pickers

Version bump

Updated manifest.json

Updated manifest.json for V3

Bumped version number

Bumped version number

Added Manifest V3 compatibility for Firefox

Added manifest-firefox.json to README.md

Changed build to be an alias to build:chrome

Added web-ext for linting and npm run lint:firefox

Regenerated package-lock.json

Added linting for Firefox in GH actions

Bumped versions

fix: upgrade multiple dependencies with Snyk

Snyk has created this PR to upgrade:
  - @babel/core from 7.17.10 to 7.23.3.
    See this package in npm: https://www.npmjs.com/package/@babel/core
  - @babel/plugin-proposal-class-properties from 7.16.7 to 7.18.6.
    See this package in npm: https://www.npmjs.com/package/@babel/plugin-proposal-class-properties
  - @babel/plugin-transform-runtime from 7.17.10 to 7.23.3.
    See this package in npm: https://www.npmjs.com/package/@babel/plugin-transform-runtime
  - @babel/preset-flow from 7.16.7 to 7.23.3.
    See this package in npm: https://www.npmjs.com/package/@babel/preset-flow
  - @babel/preset-react from 7.16.7 to 7.23.3.
    See this package in npm: https://www.npmjs.com/package/@babel/preset-react

See this project in Snyk:
https://app.snyk.io/org/expensify/project/35c87b83-0578-438a-9ce5-96d21d712614?utm_source=github&utm_medium=referral&page=upgrade-pr

fix: upgrade react-dom from 18.1.0 to 18.2.0

Snyk has created this PR to upgrade react-dom from 18.1.0 to 18.2.0.

See this package in npm:
https://www.npmjs.com/package/react-dom

See this project in Snyk:
https://app.snyk.io/org/expensify/project/35c87b83-0578-438a-9ce5-96d21d712614?utm_source=github&utm_medium=referral&page=upgrade-pr
  • Loading branch information
snyk-bot authored and mjasikowski committed Oct 9, 2024
1 parent 96e200f commit 0083818
Show file tree
Hide file tree
Showing 17 changed files with 645 additions and 451 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,23 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: 0

- uses: actions/cache@v2
- name: Add build cache
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: '20.10.0'
node-version-file: '.nvmrc'

- name: Install node packages
uses: nick-fields/retry@7c68161adf97a48beb850a595b8784ec57a98cbb
Expand All @@ -31,4 +33,8 @@ jobs:
max_attempts: 5
command: npm ci

- run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs)
- name: Lint with ESLint
run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs)
- name: Lint for Firefox
run: npm run lint:firefox

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.10.0
20.15.1
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
#1.3.67
- Added additional linting and CI for Firefox

#1.3.66
- Added Firefox build script for Manifest V3 compatibility

#1.3.65
- Changed manifest.json to comply with Manifest V3

#1.3.64
- Fix the sidebar not redrawing when looking at GH issues

#1.3.63
- Allow for code owners to be assigned when there is only one person assigned
- Show on the K2 dashboard if an issue has an owner, and you're not the owner
- Add a filter for issues not owned by you

#1.3.62
- Design improvements for light and dark mode.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Sometimes it is necessary to install and enable the public version of the extens

# Creating your PR
Be sure to do the following before pushing up your branch:
1. Bump the version number in `assets/manifest.json` (use major.minor.patch version scheme)
1. Bump the version number in `assets/manifest.json` and `assets/manifest-firefox.json` (use major.minor.patch version scheme)
1. Bump the version number in `package.json` and `package-lock.json` to match
1. Add a new change log entry in `CHANGELOG.md`

Expand Down
39 changes: 39 additions & 0 deletions assets/manifest-firefox.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"manifest_version": 3,

"name": "K2 for GitHub",
"version": "1.3.67",
"description": "Manage your Kernel Scheduling from directly inside GitHub",

"browser_specific_settings": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "112.0"
}
},

"icons": {
"16": "icon16.png",
"48": "icon48.png",
"128": "icon128.png"
},

"permissions": [
"webNavigation"
],

"host_permissions": [
"*://api.github.com/*"
],

"content_scripts": [{
"matches": ["*://*.github.com/*"],
"css": ["content.css"],
"js": ["content.js"]
}],

"background": {
"scripts": ["events.js"],
"type": "module"
}
}
20 changes: 8 additions & 12 deletions assets/manifest.json
Original file line number Diff line number Diff line change
@@ -1,36 +1,32 @@
{
"manifest_version": 2,
"manifest_version": 3,

"name": "K2 for GitHub",
"version": "1.3.62",
"version": "1.3.67",
"description": "Manage your Kernel Scheduling from directly inside GitHub",

"browser_specific_settings": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "42.0"
}
},

"icons": {
"16": "icon16.png",
"48": "icon48.png",
"128": "icon128.png"
},

"permissions": [
"*://api.github.com/*",
"webNavigation"
],

"host_permissions": [
"*://api.github.com/*"
],

"content_scripts": [{
"matches": ["*://*.github.com/*"],
"css": ["content.css"],
"js": ["content.js"]
}],

"background": {
"persistent": false,
"scripts": ["events.js"]
"service_worker": "events.js",
"type": "module"
}
}
Loading

0 comments on commit 0083818

Please sign in to comment.