Put duplicate detection under a new beta #43864

pecanoro · 2024-06-17T20:18:10Z

Details

We just opened violations for everyone so we need to put dupe detection under a new beta to not break things.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/405681
$ https://expensify.slack.com/archives/C036QM0SLJK/p1718119516375829
PROPOSAL:

Tests

With your expensify account or any other that is not expensifail (which has all betas enabled):

Log in with Collect workspace's member account
Create 2 expenses with same AMOUNT, CURRENCY, MERCHANT and DATE (select one in the past) to the Collect workspace
Go to the workspace chat in which the expense report should be included.
Verify in the workspace chat, the report preview has NO red dot indicator
Go to the expense report
Verify each expense preview has NO red dot indicator and NO HOLD.
Go to the transaction report
Verify the HOLD banner is NOT there.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-17T20:18:38Z

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2024-06-18T00:48:03Z

@akinwale We need to put the new code behind a beta and since you reviewed the original PR, I was wondering if you could review and test this one too!

I would say just testing that dupe detection does not work if we have a beta. I still need to add the beta to the back-end so you can only test it does not work for now.

akinwale · 2024-06-18T18:00:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

43864-web.mp4

MacOS: Desktop

akinwale

LGTM.

melvin-bot · 2024-06-18T18:01:30Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-06-18T18:01:33Z

🎯 @akinwale, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #43940.

OSBotify · 2024-06-18T19:37:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-19T21:53:22Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:18:04Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:52:03Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T21:22:41Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2024-11-06T04:23:57Z

src/libs/TransactionUtils.ts

@@ -693,6 +704,10 @@ function hasNoticeTypeViolation(transactionID: string, transactionViolations: On
 * Checks if any violations for the provided transaction are of type 'warning'
 */
 function hasWarningTypeViolation(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>): boolean {
+    if (!Permissions.canUseDupeDetection(allBetas ?? [])) {


It caused this bug. With this change, hasWarningTypeViolation always returns false if canUseDupeDetection is false, but dupe detection is only one reason that causes a warning violation type. When a receipt scanning fails, the BE still returns a warning violation

pecanoro added 2 commits June 17, 2024 16:13

New beta

d070ad4

Check for message

3c7d2f7

pecanoro requested a review from a team as a code owner June 17, 2024 20:18

melvin-bot bot requested review from bondydaa and removed request for a team June 17, 2024 20:18

pecanoro self-assigned this Jun 17, 2024

pecanoro added 2 commits June 17, 2024 16:28

Linter

7bfda31

prettier

9a7b9ae

pecanoro requested a review from akinwale June 18, 2024 00:47

akinwale approved these changes Jun 18, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr June 18, 2024 18:01

melvin-bot bot mentioned this pull request Jun 18, 2024

[$250] Payment issue for E/App PR#43864 #43940

Closed

pecanoro removed the request for review from youssef-lr June 18, 2024 18:34

bondydaa approved these changes Jun 18, 2024

View reviewed changes

bondydaa merged commit 3c904d9 into main Jun 18, 2024
18 of 28 checks passed

bondydaa deleted the rocio-BetaDupe branch June 18, 2024 19:29

This was referenced Jun 18, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #43959

Closed

Deploy Checklist: New Expensify 2024-06-19 #44047

Closed

getusha mentioned this pull request Jul 9, 2024

[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

Closed

49 tasks

DylanDylann reviewed Nov 6, 2024

View reviewed changes

DylanDylann mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-13] [$250] RBR isn't displayed when scanning failed #50799

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put duplicate detection under a new beta #43864

Put duplicate detection under a new beta #43864

pecanoro commented Jun 17, 2024 •

edited

Loading

melvin-bot bot commented Jun 17, 2024

pecanoro commented Jun 18, 2024 •

edited

Loading

akinwale commented Jun 18, 2024

akinwale left a comment

melvin-bot bot commented Jun 18, 2024

melvin-bot bot commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 21, 2024

DylanDylann Nov 6, 2024

Put duplicate detection under a new beta #43864

Put duplicate detection under a new beta #43864

Conversation

pecanoro commented Jun 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 17, 2024

pecanoro commented Jun 18, 2024 • edited Loading

akinwale commented Jun 18, 2024

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 18, 2024

melvin-bot bot commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 19, 2024

OSBotify commented Jun 21, 2024

DylanDylann Nov 6, 2024

Choose a reason for hiding this comment

pecanoro commented Jun 17, 2024 •

edited

Loading

pecanoro commented Jun 18, 2024 •

edited

Loading