[No QA] Fix Flipper so iOS can build in Xcode 12.5 #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
May 11, 2021
chiragsalian
approved these changes
May 11, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.42-1🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
59 tasks
|
Sorry, I added the wrong link issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Mostly following the guidance of these comments here:
facebook/react-native#31179 (comment)
facebook/react-native#31179 (comment)
Fixed Issues
Fixes #2801
Tests
cd ios && rm -rf Podsnpx react-native-clean-projectwith these optionspod install --repo-updatecd .. && npm run iosQA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android