Skip to content

Commit

Permalink
Merge pull request #52001 from Expensify/andrew-android-sourcemap
Browse files Browse the repository at this point in the history
[No QA]Improve file uploading to not exit on error and fix Android sourcemap path

(cherry picked from commit c99ca24)

(CP triggered by AndrewGable)
  • Loading branch information
luacmartins authored and OSBotify committed Nov 5, 2024
1 parent cf7923e commit 2efed18
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: android-hybrid-sourcemap-artifact
path: /Users/runner/work/App/App/Mobile-Expensify/Android/build/generated/sourcemaps/react/release/index.android.bundle.map
path: /home/runner/work/App/App/Mobile-Expensify/Android/build/generated/sourcemaps/react/release/index.android.bundle.map

- name: Set current App version in Env
run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV"
Expand Down Expand Up @@ -832,7 +832,11 @@ jobs:
# Loop through each file and upload individually (so if one fails, we still have other platforms uploaded)
for file_entry in "${files[@]}"; do
gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry"
gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry" || {
echo "Failed to upload $file_entry. Continuing with the next file."
continue
}
echo "Successfully uploaded $file_entry."
done
env:
GITHUB_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -891,7 +895,11 @@ jobs:
# Loop through each file and upload individually (so if one fails, we still have other platforms uploaded)
for file_entry in "${files[@]}"; do
gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry"
gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry" || {
echo "Failed to upload $file_entry. Continuing with the next file."
continue
}
echo "Successfully uploaded $file_entry."
done
env:
GITHUB_TOKEN: ${{ github.token }}
Expand Down

0 comments on commit 2efed18

Please sign in to comment.