Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inline #2710

Merged
merged 1 commit into from
Aug 3, 2023
Merged

remove inline #2710

merged 1 commit into from
Aug 3, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 20, 2023

No description provided.

@ghost
Copy link

ghost commented Jul 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Signed-off-by: Rosen Penev <[email protected]>
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2710 (7948e9b) into main (a2d6996) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2710   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22313    22313           
  Branches    10804    10804           
=======================================
  Hits        14261    14261           
  Misses       5828     5828           
  Partials     2224     2224           
Impacted Files Coverage Δ
include/exiv2/slice.hpp 90.56% <100.00%> (ø)

@kevinbackhouse
Copy link
Collaborator

What's wrong with these inline annotations? (I don't really mind either way - just interested.)

@neheb
Copy link
Collaborator Author

neheb commented Aug 2, 2023

No real reason for them. They're already namespaced.

@neheb neheb merged commit 06cf19a into Exiv2:main Aug 3, 2023
105 checks passed
@neheb neheb deleted the constexpr branch August 3, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants