-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve easyaccess documentation #2706
Improve easyaccess documentation #2706
Conversation
include/exiv2/easyaccess.hpp
Outdated
//! Return the ISO speed used to shoot the image. Please keep in mind that this accessor is provided for convenience | ||
//! only and will return expected/desired metadata most of the time. | ||
EXIV2API ExifData::const_iterator isoSpeed(const ExifData& ed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is some extra computation involved for ISO, maybe another sentence (similar to lens detection) is warranted?
@kmilos : I was not aware of this, thanks for the hint. Is following addition fine?
|
Great, thanks @norbertwg |
Codecov Report
@@ Coverage Diff @@
## main #2706 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 103 103
Lines 22313 22313
Branches 10804 10804
=======================================
Hits 14261 14261
Misses 5828 5828
Partials 2224 2224 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Refers to issue #2204 : Some explanations added to easyaccess API.