tests: do not hardcode ENOENT #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual values of errno constants are not specified in POSIX, and left as implementation details; hence, tweak the check for the ENOENT description to not check for the actual value.
Codecov Report
@@ Coverage Diff @@
## main #2700 +/- ##
=======================================
Coverage 63.90% 63.90%
=======================================
Files 103 103
Lines 22316 22316
Branches 10805 10805
=======================================
Hits 14260 14260
Misses 5831 5831
Partials 2225 2225 |
kmilos
added
platforms
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual values of errno constants are not specified in POSIX, and left as implementation details; hence, tweak the check for the
ENOENTdescription to not check for the actual value.In particular, this fixes the tests on GNU/Hurd, as its POSIX errnos do not start from 1.