Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace reinterpret_cast with memcpy #2695

Merged
merged 2 commits into from
Jul 17, 2023
Merged

replace reinterpret_cast with memcpy #2695

merged 2 commits into from
Jul 17, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 16, 2023

On mips64, this throws a cast-align warning. Silence it.

@ghost
Copy link

ghost commented Jul 16, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 16, 2023 •
edited
Loading

Codecov Report

Merging #2695 (b338f49) into main (7473b4a) will not change coverage.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##             main    #2695   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22314    22314           
  Branches    10800    10805    +5     
=======================================
  Hits        14261    14261           
  Misses       5828     5828           
  Partials     2225     2225
Impacted Files Coverage Δ
src/pgfimage.cpp 42.76% <0.00%> (ø)
src/asfvideo.cpp 53.57% <100.00%> (ø)
src/image.cpp 70.19% <100.00%> (ø)
src/jp2image.cpp 70.53% <100.00%> (ø)
src/jpgimage.cpp 68.91% <100.00%> (ø)
src/pngimage.cpp 61.12% <100.00%> (ø)
src/tiffcomposite_int.cpp 76.54% <100.00%> (ø)
src/tiffvisitor_int.cpp 80.53% <100.00%> (ø)
src/value.cpp 72.42% <100.00%> (ø)

@neheb
replace reinterpret_cast with copy_n
dcb7841 
On mips64, this throws a cast-align warning. Silence it.

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb force-pushed the al branch 2 times, most recently from d4a7e82 to aeaf212 Compare July 16, 2023 23:16
@neheb
memcpy to copy_n conversions
b338f49 
The latter is more strict regarding types

Signed-off-by: Rosen Penev <[email protected]>
kmilos
kmilos approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit 1837bf0 into Exiv2:main Jul 17, 2023
105 checks passed
@neheb neheb deleted the al branch July 17, 2023 17:02
@neheb
Copy link
Collaborator Author

neheb commented Jul 17, 2023

@Mergifyio backport 0.28.x

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023 •
edited
Loading

backport 0.28.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @kmilos