add missing commas

[neheb]

Formats the structs properly.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2691 (4a03b63) into main (029dc9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22312    22312           
  Branches    10804    10804           
=======================================
+ Hits        14260    14261    +1     
  Misses       5828     5828           
+ Partials     2224     2223    -1     

Impacted Files	Coverage Δ
src/asfvideo.cpp	53.57% <ø> (ø)
src/canonmn_int.cpp	73.17% <ø> (+0.29%)	⬆️
src/casiomn_int.cpp	6.45% <ø> (ø)
src/fujimn_int.cpp	39.62% <ø> (ø)
src/makernote_int.cpp	65.91% <ø> (ø)
src/minoltamn_int.cpp	66.52% <ø> (ø)
src/nikonmn_int.cpp	61.20% <ø> (ø)
src/olympusmn_int.cpp	45.39% <ø> (ø)
src/panasonicmn_int.cpp	52.58% <ø> (ø)
src/pentaxmn_int.cpp	71.36% <ø> (ø)
... and 8 more

[kmilos]

Perhaps roll #2690 into this please?

[postscript-dev]

@neheb

Formats the structs properly.

Is it worth changing .clang-format to enforce this?

[neheb]

What clang-format option?

[neheb]

Apparently there's InsertTrailingCommas, but that requires BinPackArguments to be false. The latter looks horrible.

[postscript-dev]

@neheb

What clang-format option?

Apparently there's InsertTrailingCommas, but that requires BinPackArguments to be false. The latter looks horrible.

Thanks for checking. A future clang-format version may provide a better option.

[neheb]

So I tried locally with BinPackArguments and InsertTrailingCommas separately. Seems there are no further changes.

[kmilos]

So I tried locally with BinPackArguments and InsertTrailingCommas separately. Seems there are no further changes.

So should we commit this to .clang-format then so everyone can use it for future changes?

[neheb]

No because it doesn't work properly.

[kmilos]

LGTM