Merge pull request #59 from BenMorel/master

Fix issue when looking up by ASIN number
Exeu · Jan 1, 2015 · a235f86 · a235f86
2 parents 12101e6 + 776f6bc
commit a235f86
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/lib/ApaiIO/Operations/Lookup.php b/lib/ApaiIO/Operations/Lookup.php
@@ -80,7 +80,7 @@ public function setIdType($idType)
 
         $this->parameter['IdType'] = $idType;
 
-        if (empty($this->parameter['SearchIndex'])) {
+        if (empty($this->parameter['SearchIndex']) && $idType != self::TYPE_ASIN) {
             $this->parameter['SearchIndex'] = 'All';
         }
 

diff --git a/tests/ApaiIO/Test/Operations/Types/LookupTest.php b/tests/ApaiIO/Test/Operations/Types/LookupTest.php
@@ -55,6 +55,40 @@ public function testGetIdType()
         }
     }
 
+    /**
+     * @dataProvider providerSetIdTypeAffectsSearchIndex
+     *
+     * @param string      $idType
+     * @param string|null $expectedSearchIndex
+     */
+    public function testSetIdTypeAffectsSearchIndex($idType, $expectedSearchIndex)
+    {
+        $lookup = new Lookup();
+        $lookup->setIdType($idType);
+
+        $parameters = $lookup->getOperationParameter();
+
+        if ($expectedSearchIndex === null) {
+            $this->assertArrayNotHasKey('SearchIndex', $parameters);
+        } else {
+            $this->assertSame($expectedSearchIndex, $parameters['SearchIndex']);
+        }
+    }
+
+    /**
+     * @return array
+     */
+    public function providerSetIdTypeAffectsSearchIndex()
+    {
+        return array(
+            array(Lookup::TYPE_ASIN, null),
+            array(Lookup::TYPE_SKU, 'All'),
+            array(Lookup::TYPE_UPC, 'All'),
+            array(Lookup::TYPE_EAN, 'All'),
+            array(Lookup::TYPE_ISBN, 'All')
+        );
+    }
+
     /**
      * @expectedException InvalidArgumentException
      */