feat/SOF-6973: use a single global template per executable #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azech-hqs
reviewed
Sep 27, 2023
azech-hqs
reviewed
Sep 27, 2023
azech-hqs
reviewed
Sep 27, 2023
azech-hqs
reviewed
Sep 27, 2023
azech-hqs
reviewed
Sep 28, 2023
seankwarren
commented
Oct 6, 2023
seankwarren
commented
Oct 9, 2023
yaosamo
reviewed
Oct 12, 2023
assets/espresso/neb.x.in.j2
Outdated
| FIRST_IMAGE | ||
| ATOMIC_POSITIONS {{atomicPositions.first.card_option}} | ||
| {% for position in atomicPositions.first -%} | ||
| {{position.X}} {{position.x}} {{position.y}} {{position.z}} {% if 'if_pos(1)' in position -%} {{position["if_pos(1)"]}} {% endif -%} {% if 'if_pos(2)' in position -%} {{position["if_pos(2)"]}} {% endif -%} {% if 'if_pos(3)' in position -%} {{position["if_pos(3)"]}} {% endif %} |
There was a problem hiding this comment.
@seankwarren why does poisiton has X and x there? what is the difference? I'm just making layout and was confused a bit
There was a problem hiding this comment.
X is the element species, while x, y, and z are the coordinates based on the docs here
| @@ -0,0 +1,11 @@ | |||
| average: &average | |||
There was a problem hiding this comment.
Where is the documentation for all the work done in this PR? For example, what is what is staticContext, common_control????
We need to clarify the approach and put it in the README
| @@ -0,0 +1,5 @@ | |||
| &BANDS | |||
| {%- for key, value in bands %} | |||
There was a problem hiding this comment.
This block is repeated everywhere below and could be defined as a macros for brevity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.