-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support draco compression in GLBRuntime #18
base: develop
Are you sure you want to change the base?
Conversation
The new version has new compiled libraries for android and uwp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as a charm in HoloLens, but I get some crashes when trying to open a model using a Meta Quest 2 device :(. Original duck model can be loaded without problem, but draco-compressed duck only loads 1 of each 3 attemps. Maybe some kind of race condition?
Need to check it with more draco compressed models to see if this is a common problem or not.
It makes sense that it crashes in HoloLens because I have removed the UAP .dll. However, I didn't remove the .dll for Android, so it's weird that it doesn't work in Quest. I suspect what might be the issue, I will take a look. |
For June release we will still support UAP in Evergine, so we need that DLL back. For September release, it's true that this will no longer supported, and you could get rid of library for that platform. |
I made a fix for this in EvergineTeam/NativeLibraryLoader#2. |
Let's wait until that PR is merged :) |
The EvergineTeam/NativeLibraryLoader#2 has been merged |
Also fixed problem loading two consecutive draco models (the decompressed data was cached, and the cache wasn't cleared for the next model)
I have updated XRV to reference to the newest Draco.NET which now uses the fixed NativeLibraryLoader. |
Thanks for trying to update this, but you should merge changes from develop branch first. As you may see, we are no longer using Model Viewer module importers, they have been replaced by Evergine.RuntimeLoders for both STL and GLB :-/. |
Does that mean that the RuntimeLoaders are now part of Evergine? The PR should be now made to the Evergine repo instead? |
Yeah, if you need to change how current runtime loader works (for example adding that cache dictionary) you should do it in Core repository. Take a look to that code first, I think it already includes changes you made on GLBRuntime class. Maybe it's enough with merging current develop branch and check that native DLLs are properly loaded via Evergine.Bindings.Draco package. |
I added a model with Draco compression in the Azure shared folder, if you want to try it out.