-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add binary string operations (length and concatenation) #3646
base: main
Are you sure you want to change the base?
Conversation
18b8ab2
to
3e0dae6
Compare
CodSpeed Performance ReportMerging #3646 will improve performances by 34.3%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
- Coverage 77.99% 76.87% -1.13%
==========================================
Files 720 733 +13
Lines 88794 93056 +4262
==========================================
+ Hits 69252 71533 +2281
- Misses 19542 21523 +1981
|
6338308
to
cf73ba2
Compare
2deddac
to
1c26a63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! In addition to the other comments there's two things you should also do:
- add these functions to our docs by adding a section in
docs/source/api_docs/expressions.rst
- implement this for the FixedSizeBinaryArray type as well
… iterator creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I had some comments on things to clean up.
Added two new binary string operations to Daft:\n\n- binary.length(): Get length of binary strings in bytes\n- binary.concat(): Concatenate two binary strings\n\nImplemented in Rust with full test coverage including ASCII, UTF-8, and special binary sequences.