Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the application's dark mode to follow the app settings on macOS. #10186

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

fireblue
Copy link
Contributor

Hi,

This pull request is a continuation of #10177

Your elegant solution completely eliminates the need to modify colorSchemeSettingsTab.component.ts/pug👍 👍

You’re amazing!

To avoid unnecessary back-and-forth changes to these two files, I’ve followed your instructions and made the adjustments. This new pull request reflects those updates.

Thanks again for your guidance!

@fireblue
Copy link
Contributor Author

fireblue commented Jan 10, 2025

Cloned Electron source code and took a look at native_window_mac.mm, the code of windows' vibrancy is quite straight forward, everything is initialized and configured in function

void NativeWindowMac::SetVibrancy(const std::string& type)

but there's no much to customize with NSVisualEffectView.
To achieve a more translucent and customizable background, implementing yet another glass like blurring background view should do the trick, but that's too heavy and possibly problematic in every way. :(

For now, current approach might be the best solution.

(From a guy who is obsessed in translucent glass backgrounds)

@Eugeny Eugeny merged commit f9dadf0 into Eugeny:master Jan 10, 2025
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Jan 10, 2025

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants