Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes for breadcrumbs and deep containment checks #1692

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dbouwman
Copy link
Member

@dbouwman dbouwman commented Oct 21, 2024

  1. Description:

Four things:

  • export parseContainmentPath from the library to apps can use it
  • fix Catalog.scopes to return {} instead of undefined if .scopes is 🥁 undefined
  • if present, data.catalogs should flow through to IHubInitiative.catalogs
  • update Catalog.contains to handle cases where there is no scope for the targetEntity, and instead execute queries for all collections.
  1. Instructions for testing: run tests

  2. Connected to #11176

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@dbouwman dbouwman changed the title fix: catalog scopes never undefined fix: small fixes for breadcrumbs and deep containment checks Oct 21, 2024
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants