Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the new Elevation service via a new arcgis-rest-elevation package #1190

Merged
merged 10 commits into from
Jan 30, 2025
Merged

Add support for the new Elevation service via a new arcgis-rest-elevation package #1190

merged 10 commits into from
Jan 30, 2025

Conversation

sherylgiovanni
Copy link
Contributor

@sherylgiovanni sherylgiovanni commented Jan 14, 2025 •
edited
Loading

gavinr-maps
gavinr-maps requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to include a README.md within the folder packages\arcgis-rest-elevation, similar to the other packages.

patrickarlt
patrickarlt requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherylgiovanni Overall this looks good but I do have a few small comments.

demos/node-elevation-api/package.json Outdated Show resolved Hide resolved
demos/node-elevation-api/readme.md Outdated Show resolved Hide resolved
packages/arcgis-rest-elevation/package.json Outdated Show resolved Hide resolved
patrickarlt
patrickarlt approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickarlt patrickarlt merged commit 9830fe3 into Esri:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickarlt patrickarlt patrickarlt approved these changes

@gavinr-maps gavinr-maps Awaiting requested review from gavinr-maps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherylgiovanni @patrickarlt @gavinr-maps