Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arcgis-rest-routing): solveRoute rawResponse #1046

Closed
wants to merge 5 commits into from

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Dec 19, 2022

fixed issue with solveRoute failing when using rawResponse: true

#1045

fixed issue with solveRoute failing when using `rawResponse: true`
@gavinr gavinr requested a review from patrickarlt December 19, 2022 16:40
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (805844b) to head (f65a64d).
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1046   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         2924      2928    +4     
  Branches       527       528    +1     
=========================================
+ Hits          2924      2928    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinr this looks good but I think we also need to figure out if we want to do this in general for #1045. Do you want to merge this or continue the discussion in #1045?

@gavinr
Copy link
Contributor Author

gavinr commented Feb 9, 2023

@patrickarlt I checked those other two cases, and they are actually already correctly working: #1045 (comment).

I did add a unit test to cover rawResponse with originDestinationMatrix.

Unless I hear any objections I will go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants