Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions #4

Merged
merged 24 commits into from
Jan 10, 2025
Merged

Instructions #4

merged 24 commits into from
Jan 10, 2025

Conversation

gavinr-maps
Copy link
Collaborator

  1. Updated all the samples to use the published (NPM or Unpkg CDN) version of ArcGIS REST JS by default.
  2. Created instructions for npm and browser based ways to use local ArcGIS REST JS.
  3. Updated the READMEs to link to the instructions ^.
  4. Updated the READMEs for consistency.

After this is merged, we can make this repository public and then delete the demos folder of ArcGIS REST JS.

patrickarlt
patrickarlt approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but otherwise this LGTM!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
samples/oauth2-browser/config.js Outdated Show resolved Hide resolved
@gavinr-maps gavinr-maps merged commit cbe887d into main Jan 10, 2025
@gavinr-maps gavinr-maps deleted the samples-and-instructions branch January 10, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickarlt patrickarlt patrickarlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinr-maps @patrickarlt