Add Changes for DualUnitLine #736
Conversation
| val endScalebarDivision = ScalebarDivision(displayLength,"3000 m") | ||
| val alternateScalebarDivision = ScalebarDivision(0.75 * displayLength,"3500 Km") |
There was a problem hiding this comment.
these values should be flipped sine the primary label is always bigger than the secondary label
| val endScalebarDivision = ScalebarDivision(displayLength,"3000 m") | |
| val alternateScalebarDivision = ScalebarDivision(0.75 * displayLength,"3500 Km") | |
| val endScalebarDivision = ScalebarDivision(displayLength,"3500 mi") | |
| val alternateScalebarDivision = ScalebarDivision(0.75 * displayLength,"3000 Km") |
There was a problem hiding this comment.
No, not necessarily
| * @since 200.7.0 | ||
| */ | ||
| @Composable | ||
| internal fun DualUnitLineScalebar( |
There was a problem hiding this comment.
I noticed that this does not work as expected when we apply padding to the modifier in the Scalebar composable and also does not work when the alignment is applied on Scalebar instead of the box.
I say we merge as is right now and I can fix it as part of my other PR
There was a problem hiding this comment.
this will also need displayWidth to be passed in
There was a problem hiding this comment.
I am assuming you mean displayLength and
No, primaryScalebarDivision provides the length of the horizontal line drawn
|
@eri9000 thanks. Merging |
Related to issue: # https://devtopia.esri.com/runtime/kotlin/issues/5194
UI and logic to display
Dual unit linescalebarSummary of changes:
Pre-merge Checklist