Add convergence check, that all primaries return identical slot maps #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check is performed by sending CLUSTER SLOTS to all masters.
It is performed before changing status 'cluster_not_ok' to 'cluster_ok'.
Two options are added:
* `{convergence_check_timeout, timeout()}`: Time to wait for replies
from the nodes. Default 1000. If zero, disables the check.
* ``{convergence_check_delay, timeout()}`: Time to wait before staring
the check after a slot map update when the cluster status is already
'cluster_ok'. Default 5000. Set to zero to disable this extra check.
Doesn't affect the above config.
Signed-off-by: Viktor Söderqvist <[email protected]>
|
@bjosv Please review at least the test case and the documented options and behaviour. Without this implementation, the test case fails. |
bjosv
reviewed
Sep 10, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
bjosv
approved these changes
Sep 11, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
changed the title
zuiderkwast
added a commit
to zuiderkwast/ered
that referenced
this pull request
Sep 11, 2024
Bump version number. This release includes two new features: 1. Use init nodes as fallback if all nodes are unavailable (Ericsson#58) 2. Add convergence check, that all primaries return identical slot maps (Ericsson#59) Signed-off-by: Viktor Söderqvist <[email protected]>
Merged
zuiderkwast
added a commit
that referenced
this pull request
Sep 11, 2024
Bump version number. This release includes two new features: 1. Use init nodes as fallback if all nodes are unavailable (#58) 2. Add convergence check, that all primaries return identical slot maps (#59) Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is performed by sending CLUSTER SLOTS to all primaries.
Two options are added:
{convergence_check_timeout, timeout()}: Time to wait for replies from the nodes. The check is performed before changing status 'cluster_not_ok' to 'cluster_ok'. Default 1000. If zero, disables the check.{convergence_check_delay, timeout()}: Time to wait before staring the check after a slot map update when the cluster status is already 'cluster_ok'. Default 5000. Set to zero to disable this extra check. Doesn't affect the above config.Fixes #57