Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Display full filename #4416

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[gui] Display full filename #4416

merged 1 commit into from
Jan 23, 2025

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Jan 8, 2025

No need for truncating long filenames in GUI.

@bruntib bruntib added this to the release 6.25.0 milestone Jan 8, 2025
@bruntib bruntib requested a review from cservakt January 8, 2025 13:41
@bruntib bruntib requested a review from vodorok as a code owner January 8, 2025 13:41
cservakt
cservakt reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@cservakt cservakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding :title prop to tags of ReportTreeLabel can be a great external feature for checking filename and others easily.

@bruntib bruntib force-pushed the too_long_filenames branch from 2edef2f to 402ac55 Compare January 22, 2025 13:53
@bruntib bruntib requested a review from cservakt January 22, 2025 13:53
@bruntib
[gui] Display full filename
6b20ba1 
No need for truncating long filenames in GUI.
@bruntib bruntib force-pushed the too_long_filenames branch from 402ac55 to 6b20ba1 Compare January 22, 2025 14:25
cservakt
cservakt approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@cservakt cservakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good to me.

@bruntib bruntib merged commit 3386978 into Ericsson:master Jan 23, 2025
8 checks passed
@bruntib bruntib deleted the too_long_filenames branch January 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cservakt cservakt cservakt approved these changes

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

Assignees
No one assigned
Labels
GUI 🎨
Projects
None yet
Milestone
release 6.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bruntib @cservakt